Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update pyglet to latest #54

Closed
wants to merge 1 commit into from
Closed

update pyglet to latest #54

wants to merge 1 commit into from

Conversation

aiAdrian
Copy link
Contributor

@aiAdrian aiAdrian commented Oct 27, 2023 •
edited
Loading

Changes

pyglet version 1.3.2 doesn't no longer supported with python 3.8< under windows.

Related issues

Link to every issue from the issue tracker (if any) you addressed in this PR.

Checklist

  • Tests are included for relevant behavior changes.
  • Documentation is added in the docs folder for relevant behavior changes. If you made important user-facing
    changes, describe them under the [Unreleased] tag in CHANGELOG.md.
  • New package dependencies are declared in the pyproject.toml file.
    Requirement files have been updated by running tox -e requirements.
  • Code works with all supported Python versions (3.8, 3.9 and 3.10). Checks run with all three version and are
    required to run successfully.
  • Code is formatted according to PEP 8 (an IDE like PyCharm can do this for you).
  • Technical guidelines listed in CONTRIBUTING.md are followed.

@aiAdrian aiAdrian requested a review from a team as a code owner October 27, 2023 19:21
@aiAdrian aiAdrian linked an issue Oct 27, 2023 that may be closed by this pull request
Rendering issue under windows: pyglet must be updated #53
Closed
@aiAdrian
Copy link
Contributor Author

tested:
windows with python 3.8
linux with python 3.8

----------------- ok

pyglet 2.0.9

@fnberta
Copy link
Contributor

fnberta commented Oct 27, 2023

While this might resolve the issue, I would not recommend this approach. The idea of requirements.txt is that it pins exact versions, so that everyone gets exactly the same packages. Moreover, these files are generated from pyproject.toml and should not be edited by hand because the generation step includes the latest version that match the constraints specified in pyproject.toml. Currently, we have a constraint of gym=0.14.0 in there which is the reason pyglet gets installed with such a low version.

Please see my comments in #53 and #55. The easiest "proper" solution would be to get rid of gym which apparently is something we want to do anyway (#26).

@aiAdrian
Copy link
Contributor Author

Oh. I don't know that the pyproject.toml file is the master. Thus we can delete this PR and Branch as well?

@fnberta
Copy link
Contributor

fnberta commented Oct 29, 2023

Yes, I think we can close it especially since you now implemented #56!

@fnberta fnberta closed this Oct 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Rendering issue under windows: pyglet must be updated
2 participants
@aiAdrian @fnberta